Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Account hoisting #88

Merged
merged 16 commits into from
Jan 11, 2024
Merged

[Feature] Account hoisting #88

merged 16 commits into from
Jan 11, 2024

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Dec 18, 2023

Description

  • refactored to useAccount function
  • made where applicable account param optional and extracted from web3provider
  • minor fixes to imports

TODO:

  • tests
  • getWeb3Address deprecation message

Testing notes

Checklist:

  • Checked the changes locally.
  • Created/updated unit tests.
  • Created/updated README.md.

@Jeday Jeday changed the base branch from main to develop December 18, 2023 07:12
@Jeday Jeday marked this pull request as ready for review December 25, 2023 07:10
@Jeday Jeday requested a review from a team as a code owner December 25, 2023 07:10
@Jeday Jeday requested a review from DiRaiks January 11, 2024 11:48
@Jeday Jeday merged commit 561eed9 into develop Jan 11, 2024
3 checks passed
@Jeday Jeday deleted the feature/si-1097-account-hoisting branch January 11, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants